[MC-1539] Provide backup stories for "Need to Know" feed #671
+88
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fetch yesterday's stories if today's batch doesn't have enough "Need to Know" stories. Use time-sensitive stories from yesterday's batch. - Update integration tests.
nina-py
force-pushed
the
MC-1539-take-two
branch
from
58db809
to
717d5dd
Compare
nina-py
force-pushed
the
MC-1539-take-two
branch
from
3144de0
to
de7d98e
Compare
nina-py
force-pushed
the
MC-1539-take-two
branch
from
de7d98e
to
6149020
Compare
nina-py
commented
Oct 23, 2024
| @@ -266,6 +266,11 @@ def rank_need_to_know_recommendations( | |||
| # Filter out all time-sensitive recommendations into the need_to_know feed | |||
| need_to_know_feed = [r for r in recommendations if r.isTimeSensitive] | |||
|
|
|||
| # If fewer than five stories have been curated for this feed, use yesterday's data | |||
| if len(need_to_know_feed) < 5: | |||
| yesterdays_recs = await self.fetch_backup_recommendations(surface_id) | |||
There was a problem hiding this comment.
I initially called the fetch function here directly, but split it out to be able to unit-test the parent method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
JIRA: https://mozilla-hub.atlassian.net/browse/MC-1539
Description
Fetch yesterday's stories if today's batch doesn't have enough "Need to Know" stories. Use time-sensitive stories from yesterday's batch.
Update integration tests.
PR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title (if applicable)[load test: (abort|warn)]keywords are applied (if applicable)